Make sure test kit migrators are run only once #154446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsoldevila
added
bug
|
Pinging @elastic/kibana-core (Team:Core) |
💚 Build Succeeded
Metrics [docs]Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
To update your PR or re-run it, just comment with: |
pgayvallet
approved these changes
Apr 6, 2023
| @@ -385,6 +391,7 @@ export const getIncompatibleMappingsMigrator = async ({ | |||
| }; | |||
|
|
|||
| export const readLog = async (logFilePath: string = defaultLogFilePath): Promise<string> => { | |||
| await delay(0.1); | |||
There was a problem hiding this comment.
:i_see_what_you_did_there:
rudolf
added
the
Epic:ScaleMigrations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #152472 (hopefully)
In the failing test, we were reusing the kibana migrator test kit migrator more than once.
This can lead to unexpected results, as the
runMigrations()method closes and flushes logging appenders when it is run.This PR ensures that each migrator in the test kit is run only once.